Conversation
clang has started generating a -Wc11-extensions warning when compiling programs/prog_util.c and programs/tgetopt.c, because glibc's string.h started using _Generic. Let's go ahead and just upgrade the targeted C standard from C99 to C11. Even MSVC supports it now (though this does bump the requirement from Visual Studio 2015 to 2019 v16.8).
ac0266b to
0b6e8be
Compare
Now that C11 is targeted, 'restrict' is now always supported.
MSVC doesn't drop the restrict qualifier from arguments when assessing
function prototype compatibility, causing warning C4113 on the line
'decompress_func_t decompress_impl = dispatch_decomp;'. Work around
this by adding restrict qualifiers to dispatch_decomp().
Note that MSVC's behavior seems to violate the following from C11:
In the determination of type compatibility and of a composite type,
each parameter declared with function or array type is taken as
having the adjusted type and each parameter declared with qualified
type is taken as having the unqualified version of its declared
type.
The windows-visualstudio-build-and-test job stopped being able to find zlib because the filename changed. Update the filename.
Ubuntu shipped a clang version that broke backwards compatibility by requiring evex512 and no-evex512 flags. It was rolled back in the next version, but for now, this workaround is still needed. Fixes the "Build and test (x86_64, ubuntu-24.04, clang)" job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.